Add TTY check and debounce behavior; update README and tests#1
Merged
Add TTY check and debounce behavior; update README and tests#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
0.1.1.Description
opencode-bell@0.1.1and added a "Behavior details" section documenting that the plugin only rings whenprocess.stdout.isTTYis true, debounces repeated rings within 1200ms, and uses session-specific keys whenevent.properties.sessionIDis present.withStdoutStubandwithMockedNowand expandedtest/plugin.test.jswith tests that assert ringing for supported events, silence for unsupported events, TTY gating, debounce behavior across timestamps, and session-specific debounce keys.event.propertiesby keeping the existing test that verifies no rejection whenpropertiesis absent.Testing
node:testvia the repositorynpm testcommand) which executed the updatedtest/plugin.test.jstests.event.propertiesalso passed.Codex Task